fix to be solf-contained and more reliable

1 files changed, 17 insertions, 6 deletions

diff --git a/src/string/strcmp.c b/src/string/strcmp.c
index fdceeb67..f8863fba 100644
--- a/src/string/strcmp.c
+++ b/src/string/strcmp.c
@@ -4,21 +4,32 @@
 /** compare strings **/
 int strcmp(const char *s1, const char *s2)
 {
-	size_t n1 = 0;
-	size_t n2 = 0;
-
 	ASSERT_NONNULL(s1);
 	ASSERT_NONNULL(s2);
 
-	n1 = strlen(s1);
-	n2 = strlen(s2);
+	while (*s1 && *s2) {
+		if (*s1 != *s2) {
+			return *s1 - *s2;
+		}
+		s1++;
+		s2++;
+	}
 
 	/*
 	RETURN(NEGATIVE, ARGUMENT(s1) is less than ARGUMENT(s2));
 	RETURN(ZERO, ARGUMENT(s1) is equal to ARGUMENT(s2));
 	RETURN(POSITIVE, ARGUMENT(s1) is greater than ARGUMENT(s2));
 	*/
-	return strncmp(s1, s2, n1 < n2 ? n1 : n2);
+
+	if (*s1) {
+		return -1;
+	}
+
+	if (*s2) {
+		return 1;
+	}
+
+	return 0;
 }
 
 /***