diff options
| author | Jakob Kaivo <jkk@ung.org> | 2024-01-31 16:41:01 -0500 |
|---|---|---|
| committer | Jakob Kaivo <jkk@ung.org> | 2024-01-31 16:41:01 -0500 |
| commit | a05e8f1436eecb990d68bc1de8ba28721f1f387d (patch) | |
| tree | 9326aec01f2173d0d24190c160d788338c4ffd85 | |
| parent | d792c9d2797a5160e23827abdc71bfe500009cd3 (diff) | |
add UB checks for fields out of range
| -rw-r--r-- | src/time/asctime.c | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/src/time/asctime.c b/src/time/asctime.c index 3ca8f5ff..d87b6d8d 100644 --- a/src/time/asctime.c +++ b/src/time/asctime.c @@ -2,6 +2,12 @@ #include <time.h> #include "_safety.h" +#define CHECKRANGE(field, min, max) do {\ + if (timeptr->tm_##field < min || timeptr->tm_##field > max) { \ + __undefined("In call to asctime(), the field tm_%s (%d) is out of range [%d, %d] in the provided time", #field, timeptr->tm_##field, min, max); \ + } \ +} while (0) + /** convert broken down time to string **/ char * asctime(const struct tm * timeptr) @@ -16,6 +22,16 @@ char * asctime(const struct tm * timeptr) static char result[26]; SIGNAL_SAFE(0); + ASSERT_NONNULL(timeptr); + + CHECKRANGE(sec, 0, 60); + CHECKRANGE(min, 0, 59); + CHECKRANGE(hour, 0, 23); + CHECKRANGE(mday, 1, 31); + CHECKRANGE(mon, 0, 11); + CHECKRANGE(year, -900, 8100); + CHECKRANGE(wday, 0, 6); + CHECKRANGE(yday, 0, 365); sprintf(result, "%.3s %.3s%3d %.2d:%.2d:%.2d %d\n", days[timeptr->tm_wday], months[timeptr->tm_mon], |