From 17a6074c3ce52752afd8a367498610224fb4930d Mon Sep 17 00:00:00 2001 From: Jakob Kaivo Date: Sat, 3 Aug 2019 08:08:16 -0400 Subject: clean up main loop with alias path = argv[optind] --- rm.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/rm.c b/rm.c index 5af4415..1602224 100644 --- a/rm.c +++ b/rm.c @@ -128,29 +128,30 @@ int main(int argc, char **argv) } do { - char base[strlen(argv[optind]) + 1]; - strcpy(base, argv[optind]); + char *path = argv[optind]; + char base[strlen(path) + 1]; + strcpy(base, path); char *b = basename(base); if (!strcmp(b, "/") || !strcmp(b, ".") || !strcmp(b, "..")) { - fprintf(stderr, "rm: %s: deletion not allowed\n", argv[optind]); + fprintf(stderr, "rm: %s: %s\n", path, strerror(EINVAL)); retval = 1; continue; } struct stat st; - if (lstat(argv[optind], &st) != 0) { + if (lstat(path, &st) != 0) { if (mode != FORCE) { - fprintf(stderr, "rm: %s: %s\n", argv[optind], strerror(errno)); + fprintf(stderr, "rm: %s: %s\n", path, strerror(errno)); retval = 1; } continue; } if (recursive) { - nftw(argv[optind], rm, OPEN_MAX, FTW_DEPTH | FTW_PHYS); + nftw(path, rm, OPEN_MAX, FTW_DEPTH | FTW_PHYS); } else { - rm(argv[optind], &st, 0, NULL); + rm(path, &st, 0, NULL); } } while (++optind < argc); -- cgit v1.2.1